Rewrite and re-enable some hardware intrinsic tests #20552
Conversation
|
@CarolEidt @tannergooding PTAL |
|
@dotnet-bot test Windows_NT x64 Checked jitsse2only @dotnet-bot test Windows_NT x86 Checked jitsse2only @dotnet-bot test Ubuntu x64 Checked jitsse2only |
|
@dotnet-bot test Ubuntu x64 Checked Innerloop Build and Test |
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.props))\dir.props" /> | ||
| <PropertyGroup> |
There was a problem hiding this comment.
How long does this run? Should it possibly be priority 1, i.e.:
<CLRTestPriority>1</CLRTestPriority>
Also, I took a brief look at the test, and I think it should be wrapped in a try/catch so that we don't consider it passing if it throws an exception.
There was a problem hiding this comment.
By default, it just runs < 1s (usually we modify it to run longer for perf analysis).
There was a problem hiding this comment.
OK, sounds good - probably good to have it as a pri0 test then.
There was a problem hiding this comment.
we don't consider it passing if it throws an exception.
This program is wrapped by if(Avx2.IsSupported), so it never throws PNSE. For other exception code, let me remove the old code copied from the Raytracer benchmark (e.g., ObjectPool.cs) in the next PR.
There was a problem hiding this comment.
@fiigii do you plan to modify it to wrap the main code in a try/catch?
There was a problem hiding this comment.
Could you file an issue so that this doesn't get forgotten?
I'm not concerned about catching PNSE - the point is to catch any unexpected exception and report failure.
There was a problem hiding this comment.
@CarolEidt Thank you for the suggestions, logged at https://github.com/dotnet/coreclr/issues/20557. I will submit a PR by the end of this week.
|
Just curious, with the new release-mode flags, will legs like |
|
@danmosemsft "jitsse2only" ( |
Rewrite and re-enable some hardware intrinsic tests Commit migrated from dotnet/coreclr@7e7570d
Rewrite and re-enable hardware intrinsic tests that were disabled in #20310